Please remember that WiKirby contains spoilers, which you read at your own risk! See our general disclaimer for details.

Template talk:Good

From WiKirby, your independent source of Kirby knowledge.
Jump to navigationJump to search

should we add <includeonly>[[Category:Good pages]]</includeonly>to this? ---PinkYoshiFan 18:13, 27 April 2020 (UTC)

Yeah, because an article with this template never goes without the category. --DeepFriedCabbage 19:38, 27 April 2020 (UTC)
No. The reason we don't is because files and audio can also be marked as good, for which we have Category:Good images and Category:Good audio. --YFJ (talk · edits) 19:43, 27 April 2020 (UTC)
Oh; I thought the same category applied to all of the wiki's Good Content. --DeepFriedCabbage 19:47, 27 April 2020 (UTC)
Could we do separate templates for those and have the templates have their corresponding categories, or would that be too hard and uneseccary? ---PinkYoshiFan 19:49, 27 April 2020 (UTC)
@Pinkyoshifan, YoshiFlutterJump, Obsessive Mario Fan: How about adding a 1= parameter that would check if it's an image, audio, or article? image and picture will result in Category:Good images, audio and sound will result in Category:Good audio, and page and article will result in Category:Good pages. Should be easy to do with #if. Pandakekok9 (talk) 07:03, 23 May 2020 (UTC)
And if there's no text in the 1= param, it defaults to Category:Good pages. Pandakekok9 (talk) 07:04, 23 May 2020 (UTC)
Actually, it should be #switch:. Anyway, I got my solution working now, see my sandbox. If there's no objections, I will be implementing it. pandakekok9 (poyo) 12:11, 24 May 2020 (UTC)
I really like this idea, but will it retroactively affect images and audio that previously didn't use the parameter? Because I could see that being an issue, and we would need to add the image or audio parameter to all those. Even if we can somehow do it with a text replacement, that's something to keep in mind. Regardless, really nice work here, this change certainly will help a lot. Gigi (talk) 12:28, 24 May 2020 (UTC)

Yeah, that could be an issue, because it looks like it would, but we can do text replacements for specific namespaces. But how to differentiate between audio and images... ---PinkYoshiFan 12:30, 24 May 2020 (UTC)

Not a problem. The images are already in Category:Good images, and the audio files in Category:Good audio. A few text replacements wouldn't be hard, so I think this could work. --YFJ (talk · edits) 12:34, 24 May 2020 (UTC)
Yeah, an automated tool can look for both {{Good}} and either Category:Good images or Category:Good audio, and then replace {{Good}} with {{Good|image}} or {{Good|audio}} respectively, then remove the good category as it is redundant. pandakekok9 (poyo) 12:37, 24 May 2020 (UTC)
Oh yeah, text replaces can only affect certain categories. ---PinkYoshiFan 12:40, 24 May 2020 (UTC)
I'm gonna be playing with my sandbox now for {{Aboutfile}}; if you need the code, just use this link. pandakekok9 (poyo) 10:20, 25 May 2020 (UTC)
Bump ---PinkYoshiFan 11:59, 5 August 2020 (UTC)
Another bump, sounds like a "Good" idea. Superbound (talk) 10:58, 2 November 2020 (UTC)

Implement the above (December 1, 2020 - December 15, 2020)[edit]

I think it's way long overdue already, and the template should be updated with the proposed version already. Well, there is not much new to add that wasn't said in above discussion. Here's the coding if anyone wants it. Superbound (talk) 17:47, 1 December 2020 (UTC)

  1. Seems like you've got everything squared away. I say go for it. --Samwell (talk) 17:49, 1 December 2020 (UTC)
  2. Agreed. Have at it. -- Jellytost (talk) 07:34, 2 December 2020 (UTC)
  3. Works for me as long as it's implemented properly. Will need an admin to run text replacements though. ---PinkYoshiFan 21:07, 2 December 2020 (UTC)
  4. Can only see this helping us out. It looks like you have the code together already, so yeah, support. --YFJ (talk · edits) 16:51, 6 December 2020 (UTC)

(Further) Discussion[edit]

On topic of text replacements, is it possible for text-replace running administrator to make themselves a bot for replacement time, so it doesn't clog-up RC? Superbound (talk) 12:24, 10 December 2020 (UTC)

Well, a crat can make themselves a bot while running it (YFJ did that once for a 1,000+ page one) ---PinkYoshiFan 12:29, 10 December 2020 (UTC)

New change[edit]

I'd like someone to review my new version of this template at my sandbox (permalink). It now automatically detects the file's extension, which renders the 1= parameter obsolete. So instead of typing {{Good|image}}, you can simply just type {{Good}}. To achieve this, I used Lua (credits to the authors of English Wikipedia's String module), so turning on StringFunctions is not necessary. I tested my change, and so far it works fine. pandakekok9 (poyo) 05:05, 26 December 2020 (UTC)

Implemented now per meatball:SilentAgreement, which is long overdue btw. This shouldn't really affect anything front-end. I'm not going to go mass replace the old {{Good|image}} code for every file, at least not yet. It's not really that important to do right now. But for newer pages and files, you don't have to specify the parameter. pandakekok9 (poyo) 14:00, 25 April 2021 (UTC)